fix logger path bug #5836
Merged
fix logger path bug #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinzhu
reviewed
Nov 5, 2022
utils/utils.go
Outdated
| if filepath.Base(parent) == "gorm.io" { | ||
| return parent | ||
| } | ||
| return dir |
There was a problem hiding this comment.
the returned source dir is better to includefilepath.Separator at the end?
There was a problem hiding this comment.
Do not create a new release. There is a bug in windows.
There was a problem hiding this comment.
I've created a new PR #5844 to solve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
To fix logger path bug. aa4312e
User Case Description
before:
➜ app go run . 2022/11/04 21:10:29 /Users/kvii/go/pkg/mod/gorm.io/gorm@v1.24.1/callbacks.go:134 [0.004ms] [rows:0] SELECT 1after:
➜ app go run . 2022/11/04 20:58:48 /Users/kvii/workspace/qs/gormt/app/main.go:14 [0.005ms] [rows:0] SELECT 1