Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Joins): args with select and omit #5790

Merged
merged 2 commits into from Nov 2, 2022

Conversation

a631807682
Copy link
Member

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

close #5781

User Case Description

@jinzhu jinzhu merged commit b2f4252 into go-gorm:master Nov 2, 2022
Copy link

@gaoxunyang gaoxunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not completely work
when you select more than one segment,like select("id,name")
it doesn't work

@a631807682 a631807682 deleted the fix_join_select_omit branch December 14, 2022 06:17
@a631807682
Copy link
Member Author

not completely work when you select more than one segment,like select("id,name") it doesn't work

.Select("ID", "name")

@gaoxunyang
Copy link

not completely work when you select more than one segment,like select("id,name") it doesn't work

.Select("ID", "name")

ohh, thank you, not same as directly select
i think this way is more convenient...
image

@a631807682
Copy link
Member Author

not completely work when you select more than one segment,like select("id,name") it doesn't work

.Select("ID", "name")

ohh, thank you, not same as directly select i think this way is more convenient... image

We already have a lot of support for select, and supporting it won't bring much benefit.
https://github.com/go-gorm/gorm/blob/master/tests/query_test.go#L764

@gaoxunyang
Copy link

not completely work when you select more than one segment,like select("id,name") it doesn't work

.Select("ID", "name")

ohh, thank you, not same as directly select i think this way is more convenient... image

We already have a lot of support for select, and supporting it won't bring much benefit. https://github.com/go-gorm/gorm/blob/master/tests/query_test.go#L764

ok, thanks for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joins preloading ignores select and omit clauses
4 participants