Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OnConstraint builder #5738

Merged
merged 1 commit into from Oct 7, 2022
Merged

Fix OnConstraint builder #5738

merged 1 commit into from Oct 7, 2022

Conversation

xwjdsh
Copy link
Contributor

@xwjdsh xwjdsh commented Oct 4, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Fix #5713

If OnConstraint is specified in clause.OnConflict, just ignore the columns and where target configs. Follow the document, something like ON CONFLICT xx ON CONSTRAINT yy is invalid.

@jinzhu jinzhu merged commit 9564b82 into go-gorm:master Oct 7, 2022
@xwjdsh xwjdsh deleted the bugfix/on-constraint-builder branch October 7, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clause.OnConflict generates column names even when OnConstraint is specified
2 participants
@xwjdsh @jinzhu