fix: limit=0 results (#5735) #5736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the link for the pull request to fix the sqlite module. |
|
Here is the link for the pull request to fix the sqlserver module. |
|
Please let me know if there is anything else that you need from me to move this pull request forward as it is preventing some of our services from upgrading to gorm 2. Also, given that these fixes reside in different modules it's unclear to me as to how to make the build pass. |
| @@ -4,7 +4,7 @@ import "strconv" | |||
|
|
|||
| // Limit limit clause | |||
| type Limit struct { | |||
| Limit int | |||
frankli0324
reviewed
Apr 10, 2023
| @@ -8,18 +8,26 @@ import ( | |||
| ) | |||
|
|
|||
| func TestLimit(t *testing.T) { | |||
| limit0 := 0 | |||
There was a problem hiding this comment.
test cases should not be changed unless for a reason that's good enough, this is not good enough.
bgtill
added a commit
to tillfinancial/gorm-snowflake
that referenced
this pull request
Oct 12, 2023
GORM Introduced a breaking change here: go-gorm/gorm#5736 This PR makes changes to mitigate that issue. A simmilar aproach was taken here: go-gorm/sqlserver#70 go-gorm/sqlite#114
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
User Case Description