fix: func (schema *Schema) guessRelation(...) primaryFields are overwritten
#5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoManito
force-pushed
the
fix/relationship/maybe-nil-panic
branch
2 times, most recently
from
118cf28
to
803bd1f
Compare
|
Hi @demoManito can you add some tests that might reproduce the panic? |
Hello @jinzhu The else block redeclares Line 373 in 0b7113b Line 432 in 0b7113b |
demoManito
force-pushed
the
fix/relationship/maybe-nil-panic
branch
from
803bd1f
to
76941f3
Compare
demoManito
commented
Oct 3, 2022
| } | ||
| } else { | ||
| var primaryFields []*Field |
There was a problem hiding this comment.
This repeat and covered with the outer layer
There was a problem hiding this comment.
This will cause the original 469 line to start, and the primaryKeys will always be empty
demoManito
changed the title
demoManito
changed the title
func (schema *Schema) guessRelation(...) primaryFields are overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
User Case Description