DryRun for migrator #5689
Merged
DryRun for migrator #5689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daheige
approved these changes
Oct 13, 2022
jinzhu
reviewed
Oct 20, 2022
migrator/migrator.go
Outdated
| execTx := queryTx | ||
| if m.DB.DryRun { | ||
| queryTx.DryRun = false | ||
| execTx = m.DB.Session(&gorm.Session{Logger: &printSQLLogger{}}) |
There was a problem hiding this comment.
the printSQLLogger should reuse the current logger to print the running SQL?
There was a problem hiding this comment.
The existing logger print some tracing text, so we can not copy the output to execute it.
I think a new logger printSQLLogger is necessary.
There was a problem hiding this comment.
Any other suggestion on this PR? @jinzhu
|
Any progress on this PR? This would be a great feature! |
jinzhu
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Print SQL in AutoMigrate with DryRun option.
User Case Description
As mentioned in #3545.