Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize: code logic db.scanIntoStruct() #5633

Merged
merged 1 commit into from Sep 5, 2022

Conversation

demoManito
Copy link
Member

@demoManito demoManito commented Aug 23, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Optimize code logic func (db *DB) scanIntoStruct(rows Rows, reflectValue reflect.Value, values []interface{}, fields []*schema.Field, joinFields [][2]*schema.Field)

User Case Description

NONE

@demoManito
Copy link
Member Author

demoManito commented Aug 23, 2022

@jinzhu please codereview

@jinzhu jinzhu merged commit f78f635 into go-gorm:master Sep 5, 2022
@demoManito demoManito deleted the fix/codelogic branch May 5, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants