Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrator support type aliases #5627

Merged
merged 3 commits into from Sep 22, 2022
Merged

feat: migrator support type aliases #5627

merged 3 commits into from Sep 22, 2022

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Aug 19, 2022 •
edited

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

There are many aliases for database types, and the user defines the same type, no matter which type, column alter should be avoided.
For example

-- pgsql
smallint <-> int2
integer <-> int4 
bigint <-> int8
decimal <->  numeric

-- mysql
bool <-> tinyint

related to
go-gorm/postgres#123
#5625
go-gorm/postgres#111
#5499

User Case Description

@emilhakobian emilhakobian mentioned this pull request Sep 10, 2022
Closed
@jinzhu jinzhu merged commit 73bc53f into go-gorm:master Sep 22, 2022
@a631807682 a631807682 deleted the feat_type_aliases branch September 22, 2022 07:59
jinzhu pushed a commit that referenced this pull request Sep 22, 2022
@a631807682 @jinzhu
feat: migrator support type aliases (#5627)
a289321 
* feat: migrator support type aliases

* perf: check type
This was referenced Sep 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a631807682 @jinzhu