Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inner join #5583

Merged
merged 5 commits into from Dec 24, 2022
Merged

feat: support inner join #5583

merged 5 commits into from Dec 24, 2022

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Aug 6, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

related to #4872 (comment)

I also don't think right join is necessary, so only inner join is supported.

User Case Description

@williamfinn
Copy link

@a631807682 I think a good alternative of going forward with this is to incorporate it somehow into the current Join function. this is where I wish we had kwargs in go 😄. Thoughts ?

@jinzhu jinzhu merged commit 1935eb0 into go-gorm:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants