Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(MigrateColumn): mock alter column to improve field compare #5499

Merged
merged 6 commits into from Dec 24, 2022

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Jul 9, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

A way for improve compare field in different drivers.
We can find the following problems
postgres:

smallint -> int2
integer -> int4 
bigint -> int8
decimal ->  numeric

mysql:

bool -> tinyint

sqlserver:

value, ok = columnType.DefaultValue()
// ok alway true, means default value not null

User Case Description

@jinzhu
Copy link
Member

jinzhu commented Jul 14, 2022

Hi @a631807682

Seems tests failed, this PR not ready?

@a631807682
Copy link
Member Author

@jinzhu Yes, this PR should not be merged unless the issues that occurred in all drivers are fixed. Now its purpose is to find the problem in driver MigrateColum.

@a631807682 a631807682 marked this pull request as draft July 14, 2022 12:16
@jinzhu jinzhu marked this pull request as ready for review October 7, 2022 10:33
@jinzhu jinzhu merged commit 794edad into go-gorm:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants