fix: return id which have type string after created

[nohattee]

• Do only one thing
• Non breaking API changes
• Tested

What did this pull request do?

Returning the ID which has uuid.UUID or String type after created

User Case Description

I have a sql script like the below and run on Postgres DB:

CREATE TABLE "users" (
    "id" UUID NOT NULL DEFAULT gen_random_uuid(),
    "email" TEXT NOT NULL,
    "password" TEXT,
    "created_at" TIMESTAMP(3) NOT NULL DEFAULT CURRENT_TIMESTAMP,
    "updated_at" TIMESTAMP(3) NOT NULL,
    "deleted_at" TIMESTAMP(3),
    CONSTRAINT "users_pkey" primary KEY ("id")
);

In the golang code, I created a struct like this:

type User struct {
	ID        uuid.UUID      `json:"id"`
	Email     string         `json:"email"`
	Password  string         `json:"password"`
	CreatedAt time.Time      `json:"created_at"`
	UpdatedAt time.Time      `json:"updated_at"`
	DeletedAt gorm.DeletedAt `json:"deleted_at"`
}

I use this method to create user:

user := &User{
         Email:    newUser.Email,
         Password: newUser.Password,
}
result := db.Select("Email", "Password").Create(user)
fmt.Println(user)

The ID was not return after created, so that the user.ID has zero value (not expected).

[jinzhu]

Hi @nohattee

Can you add some tests?

[nohattee]

Hi @jinzhu
For adding test cases, I need to create a table that has a DEFAULT gen_random_uuid() value like this:

CREATE TABLE "users" (
    "id" UUID NOT NULL DEFAULT gen_random_uuid(),
    "email" TEXT NOT NULL,
    "password" TEXT,
    "created_at" TIMESTAMP(3) NOT NULL DEFAULT CURRENT_TIMESTAMP,
    "updated_at" TIMESTAMP(3) NOT NULL,
    "deleted_at" TIMESTAMP(3),
    CONSTRAINT "users_pkey" primary KEY ("id")
);

Do you know how to create a thing like that? Please show me and I will add more test cases

[jinzhu]

Hi , you can define a struct with default tag for example:

https://gorm.io/docs/create.html#Default-Values

Also refer tests/postgres_test.go

[nohattee]

hi @jinzhu , I just added some test cases. Please help me double-check it.

[a631807682]

Hi @nohattee
Can the difference be reflected in the test? Can a test case fail before the change and succeed after the change?
It seems to me that it can be handled here https://github.com/go-gorm/gorm/blob/master/schema/schema.go#L227

[nohattee-manabie]

Hi @a631807682
This case is kind of hard to reproduce. I need to generate a table with the SQL script and the struct like User Case Description . But it seems there is no way to do that in gorm

[a631807682]

Hi @a631807682 This case is kind of hard to reproduce. I need to generate a table with the SQL script and the struct like User Case Description . But it seems there is no way to do that in gorm

Do you mean there is a difference between ddl and model? you can use Table(..).AutoMigrate() to create table, and use other model to create records.
refer to https://github.com/go-gorm/gorm/blob/master/tests/migrate_test.go#L627