Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset null value in slice #5417

Merged
merged 2 commits into from Jun 14, 2022
Merged

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Jun 12, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

closes #5415
closes #5414

Slice elem will reuse after #5388, so the null value should be updated, and we should change judge relValue.IsNil() in join.

Seems like a breaking change now, I'm not sure if revert is required as user-defined Serializers may also be affected

User Case Description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants