fix missing error-check in AutoMigrate #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -99,7 +99,10 @@ func (m Migrator) AutoMigrate(values ...interface{}) error { | |||
| } | |||
| } else { | |||
| if err := m.RunWithValue(value, func(stmt *gorm.Statement) (errr error) { | |||
| columnTypes, _ := m.DB.Migrator().ColumnTypes(value) | |||
| columnTypes, err := m.DB.Migrator().ColumnTypes(value) | |||
There was a problem hiding this comment.
this err is shadowing the previous one, you can remove the :
There was a problem hiding this comment.
It is the local error inside function literal scope, which returns error as well. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Error check was missing in AutoMigrate.
Due to this miss, errors of underlying drivers might not be delivered, resulting in misleading error texts.
Example of such behavior is showed in #5282, which is
duplicate column name: idbut real error was in SQLite driver, namelyinvalid ddlUser Case Description