Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tables lost when joins exists in from clause #5217

Closed
chein-huang opened this issue Apr 1, 2022 · 2 comments
Closed

tables lost when joins exists in from clause #5217

chein-huang opened this issue Apr 1, 2022 · 2 comments
Labels

Comments

@chein-huang
Copy link

in file: callbacks/query.go

97		joins := []clause.Join{}
98		if fromClause, ok := db.Statement.Clauses["FROM"].Expression.(clause.From); ok {
99			joins = fromClause.Joins
100		}
101
102		if len(db.Statement.Joins) != 0 || len(joins) != 0 {
...
189			db.Statement.AddClause(clause.From{Joins: joins})
190			db.Statement.Joins = nil
191		} else {
...
@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Apr 1, 2022
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@jinzhu
Copy link
Member

jinzhu commented Apr 3, 2022

thank you for your pr #5218

@jinzhu jinzhu closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants