Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw err if association model miss primary key #5187

Merged
merged 1 commit into from Mar 24, 2022

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Mar 23, 2022

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

If Association Model missing primary field, it will execute sql like:

DELETE FROM `client_operators` WHERE client_id = 5 AND `client_operators`.`client_id` IN (NULL) AND `client_operators`.`operator_id` = 1

But if there is no primary field, we can't delete it, so we should throw an error.

close #5180

@jinzhu jinzhu merged commit 3d7019a into go-gorm:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behaviour deleting associations
2 participants