Added offset when scanning the result back to struct #5143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huacnlee please take a look |
|
Hello @Joker666 Can you add some tests? |
|
@jinzhu Added a test. But I am not sure why this check has failed though. https://github.com/go-gorm/gorm/runs/5538082130?check_suite_focus=true Haven't worked on anything for the |
|
I guess that was a random failure |
|
Hi, @jinzhu I missed that. Thanks for merging. I just deleted my comment once I found out that it got merged and you commented. So, I'm closing the issue as well. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
The solution is inspired by Gorm V1. To avoid always picking the same value from the
LookUpFieldmethod we create afieldsarray and keep track of already picked values using an offset. In Gorm 1, this was the default way to scan results back.close #5142
This fixes the demo PR for the playground - go-gorm/playground#443
User Case Description
The issue in question occurs because we are using the
LookUpFieldmethod of theschemapackage. This method just looks for thenamein the map and returns the firstfieldit gets. So we get this scenario where two tables have the same column names and we do aJOINquery, it returns values that might be from a different table to a struct that should not have it.