fix: soft delete for join #5132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a631807682
commented
Mar 7, 2022
soft_delete.go
Outdated
| @@ -82,6 +82,24 @@ func (sd SoftDeleteQueryClause) ModifyStatement(stmt *Statement) { | |||
| }}) | |||
| stmt.Clauses["soft_delete_enabled"] = clause.Clause{} | |||
| } | |||
|
|
|||
| // Modify for Joins[i].ON exprs | |||
| if _, ok := stmt.Clauses["soft_delete_join_enabled"]; !ok && !stmt.Statement.Unscoped { | |||
There was a problem hiding this comment.
It doesn't seem like a good way to update an join exprs here, but it fits the function name and doesn't break the changes.
Or should we create a new interface for custom QueryClauses to genegate exprs that need to be added, and then append in BuildQuerySQL
jinzhu
pushed a commit
that referenced
this pull request
Mar 17, 2022
commit a83023bdfc0dc6eaccc6704b64ff6436c2fe7725
Author: Jinzhu <wosmvp@gmail.com>
Date: Fri Mar 18 01:05:25 2022 +0800
Refactor #5132
commit 8559f51
Author: chenrui <chenrui@jingdaka.com>
Date: Mon Mar 7 20:33:12 2022 +0800
fix: should add deleted_at exprs for every joins
commit 2b7a1bd
Author: chenrui <chenrui@jingdaka.com>
Date: Mon Mar 7 14:46:48 2022 +0800
test: move debug flag
commit ce13a2a
Author: chenrui <chenrui@jingdaka.com>
Date: Mon Mar 7 14:39:56 2022 +0800
fix: soft delete for join.on
|
Thank you for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Soft delete should work for Joins.ON.Exprs.
close #4918