Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preload panic when model and dest different #5130

Closed
wants to merge 3 commits into from
Closed

fix: preload panic when model and dest different #5130

wants to merge 3 commits into from

Conversation

a631807682
Copy link
Member

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Preload will panic when Mode and Dest is different schema.

 DB.Model(User{}).Preload("Account").Select("users.*, 'yo' as something").First(&result, user.ID).

close #4886

@a631807682
Copy link
Member Author

I don't know why the test will fail when i move the test func to the end of file.

@jinzhu jinzhu closed this in 5431da8 Mar 18, 2022
@jinzhu jinzhu mentioned this pull request Mar 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic when preload substruct of nested struct
1 participant
@a631807682