Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] RSS URI Access Encoding Issues #22301

Closed
OdinVex opened this issue Dec 31, 2022 · 3 comments · Fixed by #23874
Closed

[Bug] RSS URI Access Encoding Issues #22301

OdinVex opened this issue Dec 31, 2022 · 3 comments · Fixed by #23874
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Milestone

Comments

@OdinVex
Copy link

OdinVex commented Dec 31, 2022

Description

Attempting to access the RSS feed of a user that has a period in their name results in a 404. Encoding the URI with %2e works. The problem exists on try.gitea.io and my own self-hosted Gitea, as well as other publicly-facing Gitea instances.

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

N/A

Screenshots

No response

Git Version

N/A

Operating System

Linux, try.gitea.io

How are you running Gitea?

Various means, sometimes stand-alone, sometimes other sites.

Database

PostgreSQL

@yardenshoham yardenshoham added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Dec 31, 2022
@yardenshoham
Copy link
Member

I looked a bit into this. This line is weird:

username := ctx.Params(":username")

If the user has a dot in their name, it returns username.rss instead of username. Perhaps, a maintainer could say why this happens?

@lunny lunny added this to the 1.18.1 milestone Jan 1, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Jan 10, 2023

Got this problem while adding a new package type. I found the issue but I'm not sure what could be a solution. I have created an issue: go-chi/chi#781

@OdinVex
Copy link
Author

OdinVex commented Jan 10, 2023

Got this problem while adding a new package type. I found the issue but I'm not sure what could be a solution. I have created an issue: go-chi/chi#781

Definitely seems a 'same' situation. In your case, greedy seems best, assuming there is always a .extension.

@lunny lunny added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Jan 11, 2023
@lunny lunny modified the milestones: 1.18.1, 1.18.2, 1.18.3 Jan 16, 2023
@jolheiser jolheiser modified the milestones: 1.18.3, 1.18.4 Jan 23, 2023
@lunny lunny modified the milestones: 1.18.4, 1.18.5 Feb 19, 2023
@delvh delvh modified the milestones: 1.18.5, 1.18.6 Feb 22, 2023
6543 added a commit to 6543-forks/gitea that referenced this issue Apr 2, 2023
@6543 6543 modified the milestones: 1.18.6, 1.19.1 Apr 2, 2023
lunny pushed a commit that referenced this issue Apr 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants