Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-git is not "Git implementation in pure Go" #709

Closed
fiftin opened this issue Mar 10, 2023 · 3 comments
Closed

go-git is not "Git implementation in pure Go" #709

fiftin opened this issue Mar 10, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@fiftin
Copy link

fiftin commented Mar 10, 2023

Why you call it "pure Go" if you use library https://github.com/pjbgf/sha1cd which written in C?
@fiftin fiftin changed the title go-git is not "Git implementation in pure Go." go-git is not "Git implementation in pure Go" Mar 10, 2023
@fiftin
Copy link
Author

fiftin commented Mar 10, 2023

You should change description of the project or remove C dependencies. It will be honest.

@pjbgf
Copy link
Member

pjbgf commented Mar 11, 2023

The sha1cd dependency has both C and Go implementations. As of v5.6.0, go-git only uses the Go implementation.

Duplicate of #637.

@pjbgf pjbgf added the duplicate This issue or pull request already exists label Mar 11, 2023
@pjbgf
Copy link
Member

pjbgf commented Apr 12, 2023

Fixed as per #688.

@pjbgf pjbgf closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fiftin @pjbgf