New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close tcp 10.244.1.157:55258->18.205.93.0:22: use of closed network connection #70
Comments
any news about this? we're having the same issue fetch seems to work but clone doesn't |
I found the cause of this is closing the client here: https://github.com/go-git/go-git/blob/master/plumbing/transport/ssh/common.go#L94 it's weird that closing a single command closes the session and the client |
Ignore the error on close when the connection is already closed Fixes go-git#70
…losed This test is for issue go-git#70
I fixed this issue in #272 I prevented it from failing when the connection was already closed because according to a comment in the same code it is an expected behavior |
Thanks, it worked pretty well @dcu! I used your fork while the PR is approved using a replace in the go.mod |
* Fix cloning large repositories Ignore the error on close when the connection is already closed Fixes #70 * Compatibility for go 1.13 Because it's required by the pipeline * Add test for allowing to close a command when the client is already closed This test is for issue #70 * Add debug information for broken test
I am using Argo workflow which uses
gopkg.in/src-d/go-git.v4
. I am using git clone via sshThe 2 related github issues are:
Connection closed and repo files gone src-d/go-git#1033
failed to load artifacts: close tcp 10.60.1.248:51054->18.205.93.1:22: use of closed network connection argoproj/argo-workflows#1457
Some closure will be really helpful. Thanks :)
The text was updated successfully, but these errors were encountered: