Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close tcp 10.244.1.157:55258->18.205.93.0:22: use of closed network connection #70

Closed
rjdp opened this issue May 21, 2020 · 4 comments · Fixed by #272
Closed

close tcp 10.244.1.157:55258->18.205.93.0:22: use of closed network connection #70

rjdp opened this issue May 21, 2020 · 4 comments · Fixed by #272

Comments

@rjdp
Copy link

rjdp commented May 21, 2020

I am using Argo workflow which uses gopkg.in/src-d/go-git.v4 . I am using git clone via ssh
The 2 related github issues are:

Some closure will be really helpful. Thanks :)

@dcu
Copy link
Contributor

dcu commented Mar 24, 2021

any news about this? we're having the same issue

fetch seems to work but clone doesn't

@dcu
Copy link
Contributor

dcu commented Mar 25, 2021

I found the cause of this is closing the client here: https://github.com/go-git/go-git/blob/master/plumbing/transport/ssh/common.go#L94

it's weird that closing a single command closes the session and the client

dcu added a commit to dcu/go-git that referenced this issue Mar 25, 2021
Ignore the error on close when the connection is already closed

Fixes go-git#70
dcu added a commit to dcu/go-git that referenced this issue Mar 26, 2021
@dcu
Copy link
Contributor

dcu commented Mar 26, 2021

I fixed this issue in #272 I prevented it from failing when the connection was already closed because according to a comment in the same code it is an expected behavior

@nikoremi97
Copy link

Thanks, it worked pretty well @dcu! I used your fork while the PR is approved using a replace in the go.mod
I used this:
replace github.com/go-git/go-git/v5 => github.com/dcu/go-git/v5 v5.2.1-0.20210325181450-3e3eda06723b

mcuadros pushed a commit that referenced this issue Mar 26, 2021
* Fix cloning large repositories

Ignore the error on close when the connection is already closed

Fixes #70

* Compatibility for go 1.13

Because it's required by the pipeline

* Add test for allowing to close a command when the client is already closed

This test is for issue #70

* Add debug information for broken test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants