Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repos with submodules specified by relative URL cannot be cloned #266

Closed
cy-ddg opened this issue Mar 9, 2021 · 3 comments
Closed

Repos with submodules specified by relative URL cannot be cloned #266

cy-ddg opened this issue Mar 9, 2021 · 3 comments

Comments

@cy-ddg
Copy link

cy-ddg commented Mar 9, 2021

Trying to clone a repository that is located in git@gitlab.com:path/to/my/repo.git (or https://gitlab.com/path/to/my/repo.git, doesn't matter) and containing the following .gitmodules:

[submodule "subpath"]
	path = subpath
	url = ../another/repo.git

Results in the error:

repository not found

The repository git@gitlab.com:path/to/another/repo.git or https://gitlab.com/path/to/another/repo.git exists and the clone using the git command line tool works.

Are submodules with relative URLs not supported?

@juanjoku
Copy link

Hello,

I have also reproduced that error.
The go-git project has been moved to https://github.com/go-git/go-git, and new version v5.3.0 fixes the bug.

https://github.com/go-git/go-git/releases/tag/v5.3.0 ("Submodule: fix relative submodule resolution")

@per1234
Copy link

per1234 commented Jan 11, 2023

As mentioned by juanjoku, this was fixed by #184 + #195

@cy-ddg please verify the issue is fixed for you and then close the issue.

@pjbgf
Copy link
Member

pjbgf commented Nov 17, 2023

Closing as fixed as per above. If the issue persists we can always reopen.

@pjbgf pjbgf closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants