diff: Allow srcPrefix and dstPrefix to be configured #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe these failures are unrelated to my change. Ref #51 Is there a way I can configure this change to re-check without submitting an arbitrary change? |
The default behavior here remains the same, but this change does allow consumers of the UnifiedEncoder to set their own path prefixes which will override the defaults of a/ and b/.
|
Can you provide some tests? |
Yep - latest patchset has a test which covers non-default prefixes |
|
@mcuadros Can we cut of a new release of go-git? Quite a few things have changed since 5.2 and it would be nice to be able to import these changes with go modules |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior here remains the same, but this change does
allow consumers of the UnifiedEncoder to set their own path prefixes
which will override the defaults of a/ and b/.
Setting this should be analogous to setting
--src-prefixand--dst-prefixingit diff.See https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---src-prefixltprefixgt