Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use number set to speed up number parsing #40

Merged
merged 1 commit into from Mar 17, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Mar 17, 2022

name                           old time/op    new time/op    delta
Decoder_Float64/floats.json-4    23.4µs ± 2%    21.4µs ± 2%  -8.47%  (p=0.000 n=15+14)

name                           old alloc/op   new alloc/op   delta
Decoder_Float64/floats.json-4     0.00B          0.00B         ~     (all equal)

name                           old allocs/op  new allocs/op  delta
Decoder_Float64/floats.json-4      0.00           0.00         ~     (all equal)

name                           old time/op    new time/op    delta
Decoder_Float64/floats.json-4    23.4µs ± 2%    21.4µs ± 2%  -8.47%  (p=0.000 n=15+14)

name                           old alloc/op   new alloc/op   delta
Decoder_Float64/floats.json-4     0.00B          0.00B         ~     (all equal)

name                           old allocs/op  new allocs/op  delta
Decoder_Float64/floats.json-4      0.00           0.00         ~     (all equal)
@tdakkota tdakkota closed this Mar 17, 2022
@tdakkota tdakkota reopened this Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #40 (75b85e8) into main (fabd6f1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2309      2307    -2     
=========================================
- Hits          2309      2307    -2     
Impacted Files Coverage Δ
dec_float.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fabd6f1...75b85e8. Read the comment docs.

@tdakkota tdakkota merged commit e09ad96 into go-faster:main Mar 17, 2022
@tdakkota tdakkota deleted the feat/use-number-set branch March 17, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant