Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: array iterator #33

Merged
merged 4 commits into from Mar 13, 2022
Merged

feat: array iterator #33

merged 4 commits into from Mar 13, 2022

Conversation

tdakkota
Copy link
Member

name                     time/op
DecodeBools/Callback-12   1.67µs ± 3%
DecodeBools/Iterator-12   1.47µs ± 1%

name                     speed
DecodeBools/Callback-12  574MB/s ± 3%
DecodeBools/Iterator-12  651MB/s ± 2%

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #33 (4c906c3) into main (c929480) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        34    +1     
  Lines         2250      2302   +52     
=========================================
+ Hits          2250      2302   +52     
Impacted Files Coverage Δ
dec_arr_iter.go 100.00% <100.00%> (ø)
dec_bool.go 100.00% <0.00%> (ø)
dec_null.go 100.00% <0.00%> (ø)
dec_skip.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c929480...4c906c3. Read the comment docs.

@ernado
Copy link
Member

ernado commented Jan 24, 2022

Maybe just new Decoder method like NextElem?

@tdakkota tdakkota marked this pull request as ready for review March 11, 2022 01:25
@ernado ernado merged commit 27bf186 into go-faster:main Mar 13, 2022
@tdakkota tdakkota deleted the feat/array-iterator branch March 13, 2022 07:47
@tdakkota tdakkota mentioned this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants