Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to version echarts v5 ? #297

Closed
dh1tw opened this issue Aug 29, 2023 · 4 comments
Closed

Upgrade to version echarts v5 ? #297

dh1tw opened this issue Aug 29, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dh1tw
Copy link

dh1tw commented Aug 29, 2023

Hi,
is there any reason why the used version of echarts is (the relatively old version) 4.3?

At least the polar bar chart appears to be broken but fixed with latest echarts version (5.4.3).
The behavior can be replicated by executing the example provided in PR #157.

Tnx!

@Koooooo-7
Copy link
Member

Hi @dh1tw , sorry for the inconvenient.

TBH, thats our mistake. we does not notice that we haven't finished upgrade the default asset of echarts up to date on our side yet. 😅

As a workaround, you could do this tricky to use the echarts official resources, e.g v5.4.3, the latest.

  • On page usage
        page := components.NewPage()
	page.AssetsHost = "https://cdn.jsdelivr.net/npm/echarts@5.4.3/dist/"
  • On single chart usage
	bar := charts.NewBar()
	bar.SetGlobalOptions(
		charts.WithInitializationOpts(opts.Initialization{
			AssetsHost: "https://cdn.jsdelivr.net/npm/echarts@5.4.3/dist/",
		}),
        )

Once we finish the tests and update charts samples, we will upgrade this assets asap.

@Koooooo-7 Koooooo-7 self-assigned this Aug 30, 2023
@Koooooo-7 Koooooo-7 added enhancement New feature or request good first issue Good for newcomers labels Aug 30, 2023
@dh1tw
Copy link
Author

dh1tw commented Aug 30, 2023

Thanks for the swift reply @Koooooo-7. I have already prepared a PR for adding polar line plots (very useful for drawing antenna patterns), but it only works with version 5.

Looking forward to the update of the default asset to 5.x.!

@Koooooo-7
Copy link
Member

Thanks for the swift reply @Koooooo-7. I have already prepared a PR for adding polar line plots (very useful for drawing antenna patterns), but it only works with version 5.

Looking forward to the update of the default asset to 5.x.!

That would be great ! when we finish the upgrade, I gonna ping you here, is that okay?
Or you could raise the PR with the custom host immediately is fine also, I could do the update on your works when we upgrade the assets ( if it is necessary, in other word, I think using custom host would be a sample as well. )
tia.

@Koooooo-7
Copy link
Member

ping @dh1tw . Already upgrade to v5.4.3, plz go ahead. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants