Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded JavaScript Support Enhancements #286

Open
1 of 6 tasks
neomantra opened this issue May 11, 2023 · 0 comments
Open
1 of 6 tasks

Embedded JavaScript Support Enhancements #286

neomantra opened this issue May 11, 2023 · 0 comments
Assignees

Comments

@neomantra
Copy link
Collaborator

neomantra commented May 11, 2023

go-echarts is a cool blend of Golang, JSON, and JavaScript. As noted in this PR, in addition to string fragments one can also go:embed JavaScript files.

These embedded JavaScript function strings have certain requirements:

  • they must be quoted with single-quotes ' and not double-quotes ""
  • they also cannot contain comments.

Here's a TODO list in this realm:

  • improve documentation on restrictions on JavaScript function embedding
  • improve documentation on go:embed
  • typescript workflow example? should be able to match eCharts typings
  • add Golang simple linter function to pre-flight check JavaScript files
  • add simple linting script which can validate files
  • add a comment-stripping function (WIP in NM Various Enhancements #285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant