pre-release tags not compatible with go modules

[ryancurrah]

go mod is recommending to upgrade go-critic to pre-release versions.

As per Go:

You can specify pre-release versions by appending a hyphen and dot separated identifiers (for example, v1.0.1-alpha or v2.2.2-beta.2). Normal releases are preferred by the go command over pre-release versions, so users must ask for pre-release versions explicitly (for example, go get example.com/hello@v1.0.1-alpha) if your module has any normal releases.

https://blog.golang.org/publishing-go-modules#TOC_3.

For example the latest pre-release v0.5.0 should be similar to v0.5.0-pre.20200629042356. This way tools like dependabot.com won't try update dependancies with pre-releases. Example see this golangci PR - golangci/golangci-lint#1195.

[cristaloleg]

Hm, probably we can make it as a stable release, not pre and problem will be resolved, wdyt @quasilyte ?

[quasilyte]

It would be great to make a transition to go/analysis before doing a stable release.
Realistically speaking, it's probably better to address this issue without delaying it until that (because it's not guaranteed to happen soon).

[quasilyte]

@cristaloleg I don't see any real problems there, but I'm not familiar with pre-release and normal release differences.

[cristaloleg]

Maybe I'm (already) out of context, but from what I see, go-critic tags are well formatted x.y.z. So there is no problem with go mod.

[ryancurrah]

I think the issue was the releases were marked as pre-release on github and tagged as normal releases in modules. So if you create a Github pre-release maybe you should also create a Go module pre-release as well. That way our tools to automatically bump our go.mod dependencies won't update go-critic until you release it for everyone to use as a stable version.

[cristaloleg]

Ok, so not clicking pre-release is good enough. Anyway 0.x.y means that there is no guarantees, but we trying our best not to break something without need.

@quasilyte let's not click pre-release on a Releases page and everything should be fine. Agree?