all: integrate lintpack as internal framework #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a lintpack as a dependency, clone most of its code that we need. This is an intermediate step to make transition to go/analysis easier. Now we don't need to keep lintpack dependency in sync and can make framework/linter compatible with go/analysis later. Doing a v0.5.0 release is suggested. Updates #854 Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
cristaloleg
approved these changes
Jun 15, 2020
| @@ -40,7 +40,7 @@ cover: | |||
| goveralls -package github.com/go-critic/go-critic/checkers -coverprofile=coverage.out -service travis-ci -repotoken ${COVERALLS_TOKEN} | |||
|
|
|||
| gocritic: | |||
| lintpack build -o gocritic -linter.version='v0.4.3' -linter.name='gocritic' github.com/go-critic/go-critic/checkers | |||
| go build -o gocritic ./cmd/gocritic | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a lintpack as a dependency, clone
most of its code that we need.
This is an intermediate step to make transition to
go/analysis easier. Now we don't need to keep
lintpack dependency in sync and can make
framework/linter compatible with go/analysis later.
Doing a v0.5.0 release is suggested.
Updates #854
Signed-off-by: Iskander Sharipov quasilyte@gmail.com