checkers/internal/astwalk: adapted from a lintpack #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we might want to reduce dependencies from a lintpack project that is going to be replaced with go/analysis, it's beneficial to move useful things we want to keep inside go-critic repository. astwalk only depends on the lintpack.FileWalker interface that can be easily moved or replaced later. Refs #854 Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
cristaloleg
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we might want to reduce dependencies from
a lintpack project that is going to be replaced
with go/analysis, it's beneficial to move useful
things we want to keep inside go-critic repository.
astwalk only depends on the lintpack.FileWalker
interface that can be easily moved or replaced later.
Refs #854
Signed-off-by: Iskander Sharipov quasilyte@gmail.com