checkers: add sqlQuery checker #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasilyte
force-pushed
the
quasilyte/addCheck/sqlQuery
branch
from
684b093
to
97aa1e7
Compare
un000
reviewed
May 26, 2020
quasilyte
force-pushed
the
quasilyte/addCheck/sqlQuery
branch
from
97aa1e7
to
8269868
Compare
un000
previously approved these changes
May 26, 2020
cristaloleg
previously approved these changes
May 26, 2020
| case "Query", "QueryContext": | ||
| // Stdlib and friends. | ||
| case "Queryx", "QueryxContext": | ||
| // sqlx. |
quasilyte
force-pushed
the
quasilyte/addCheck/sqlQuery
branch
2 times, most recently
from
195e06a
to
6953d34
Compare
cristaloleg
previously approved these changes
May 26, 2020
Reports `_, err := db.Query()` pattern. Suggests to use Exec() instead of Query in this case. Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
quasilyte
force-pushed
the
quasilyte/addCheck/sqlQuery
branch
from
6953d34
to
52647af
Compare
|
Added aliases test. PR needs approval again. |
un000
approved these changes
May 26, 2020
cristaloleg
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reports
_, err := db.Query()pattern.Suggests to use Exec() instead of Query in this case.
Signed-off-by: Iskander Sharipov quasilyte@gmail.com