Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkers: add sloppyTypeAssert checker #931

Merged
merged 1 commit into from May 26, 2020
Merged

checkers: add sloppyTypeAssert checker #931

merged 1 commit into from May 26, 2020

Conversation

quasilyte
Copy link
Member 

Reports interface->interface type assertions that may be redundant.

- Any type assertion to interface{} is redundant
- Any I->I (identical) type assertion is redundant
- I1->I2 assertion is redundant if I1 implements I2

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>

@quasilyte
checkers: add sloppyTypeAssert checker
0ad8eaf 
Reports interface->interface type assertions that
may be redundant.

- Any type assertion to interface{} is redundant
- Any I->I (identical) type assertion is redundant
- I1->I2 assertion is redundant if I1 implements I2

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
cristaloleg
cristaloleg approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@quasilyte quasilyte merged commit 3916229 into master May 26, 2020
@quasilyte quasilyte deleted the quasilyte/addCheck/sloppyTypeAssert branch May 26, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quasilyte @cristaloleg