Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkers: add filepath.Join checker #930

Merged
merged 1 commit into from May 26, 2020
Merged

checkers: add filepath.Join checker #930

merged 1 commit into from May 26, 2020

Conversation

quasilyte
Copy link
Member

@quasilyte quasilyte commented May 26, 2020 •
edited 

Reports filepath.Join() string literal arguments that contain
'/' or '\' as it kinda defeats the purpose of using that function.

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>

@quasilyte
checkers: add filepath.Join checker
17f9d3b 
Reports filepath.Join() string literal arguments that contain
'/' or '\' as it kinda defeats the purpose of using that function.

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
cristaloleg
cristaloleg approved these changes May 26, 2020
View reviewed changes
checkers/testdata/filepathJoin/negative_tests.go
"path/filepath"
)

func badArgs() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are they really bad?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They could be better. 😅

@quasilyte quasilyte merged commit 9ac4766 into master May 26, 2020
@quasilyte quasilyte deleted the quasilyte/addCheck/filepathJoin branch May 26, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quasilyte @cristaloleg