checkers: add sortSlice checker #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
previously approved these changes
May 26, 2020
| } | ||
| } | ||
|
|
||
| func (c *sortSliceChecker) paramIdents(e *ast.FuncType) (*ast.Ident, *ast.Ident) { |
There was a problem hiding this comment.
?
fields := e.Params.List
if len(fields) == 2 {
return fields.Names[0], fields.Names[1]
}
return nil, nil
There was a problem hiding this comment.
This won't handle the case where both idents are a single field.
i, j int - 1 field with 2 names
i int, j int - 2 fields, each with 1 name
| @@ -10,7 +10,7 @@ require ( | |||
| github.com/go-toolsmith/astfmt v1.0.0 | |||
| github.com/go-toolsmith/astp v1.0.0 | |||
| github.com/go-toolsmith/strparse v1.0.0 | |||
| github.com/go-toolsmith/typep v1.0.0 | |||
| github.com/go-toolsmith/typep v1.0.2 | |||
Find suspicious sort slice calls. Sorting `slice` argument with a callback that uses another slice is usually incorrect, as only one slice will be modified by Slice call inplace. Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
quasilyte
force-pushed
the
quasilyte/addCheck/sortSlice
branch
from
24376c9
to
ad7ed59
Compare
|
PTAL. |
cristaloleg
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find suspicious sort slice calls.
Sorting
sliceargument with a callback that usesanother slice is usually incorrect, as only one
slice will be modified by Slice call inplace.
Signed-off-by: Iskander Sharipov quasilyte@gmail.com