don't call SizeOf for type parameters #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cristaloleg I use go1.18 locally, so I didn't mention that go-critic still uses 1.17. Do you have any plan\issue to upgrade go-critic to 1.18? I can try in separate pull request |
|
Well, that's a hard question to be honest. We should bump go-critic to Go 1.18 somewhere in July. CC: @quasilyte |
quasilyte
reviewed
Jul 8, 2022
|
The code looks good now. |
StdSizes.SizeOf method doesn't support type parameters. https://github.com/golang/go/blob/78b722d8c2f764c3048c6f0344e9ebcd2687813d/src/go/types/sizes.go#L156-L159 sdsdFixes go-critic#1223
|
@cristaloleg rebased with master |
quasilyte
approved these changes
Jul 18, 2022
|
@cristaloleg Hi, can you take a look? |
quasilyte
added a commit
to quasilyte/go-ruleguard
that referenced
this pull request
Sep 10, 2022
Extended the dsl documentation to reflect the change:
For expressions of unknown size, like type params in generics,
any filter using this operand will fail.
We're not using 0 as a fallback size to avoid the confusion
with zero-sized values like `struct{}`.
See go-critic/go-critic#1237
Fixes #406
quasilyte
added a commit
to quasilyte/go-ruleguard
that referenced
this pull request
Sep 10, 2022
Extended the dsl documentation to reflect the change:
For expressions of unknown size, like type params in generics,
any filter using this operand will fail.
We're not using 0 as a fallback size to avoid the confusion
with zero-sized values like `struct{}`.
See go-critic/go-critic#1237
Fixes #406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StdSizes.SizeOf method doesn't support type parameters. https://github.com/golang/go/blob/78b722d8c2f764c3048c6f0344e9ebcd2687813d/src/go/types/sizes.go#L156-L159
Fixes #1223