Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruleguard: add filter by tags for analyzer mode #1205

Merged
merged 12 commits into from Mar 28, 2022
Merged

ruleguard: add filter by tags for analyzer mode #1205

merged 12 commits into from Mar 28, 2022

Conversation

peakle
Copy link
Contributor

@peakle peakle commented Feb 15, 2022 •
edited

@peakle peakle changed the title add filter by tags for analyzer mode ruleguard: add filter by tags for analyzer mode Feb 15, 2022
@quasilyte
Copy link
Member

Are you sure that the default ruleset is unchanged?
Tests are failing for some reason.

@peakle
Copy link
Contributor Author

peakle commented Feb 16, 2022

Are you sure that the default ruleset is unchanged? Tests are failing for some reason.

i changed precompiled rules according to "precompiled check" on ci, will try investigate fails reason on testdata with debug-* flag tonight

@peakle
Copy link
Contributor Author

peakle commented Feb 17, 2022 •
edited

Are you sure that the default ruleset is unchanged? Tests are failing for some reason.

as i see it because you add in quasilyte/go-ruleguard#353 truncate long messages, so some test failed because part of full message was replaced by <...> pattern

tag 0.3.14 was created 26 december 2021
pr was created 9 january 2022

@peakle
Copy link
Contributor Author

peakle commented Feb 18, 2022

testdata update: go-critic/extern-testdata#4

@quasilyte
Copy link
Member

quasilyte commented Mar 28, 2022 •
edited

Looks OK, but I'm not sure about that strings.Split usage.
Also, there are integration tests (tests/_integration) that allow testing gocritic with arbitrary flags and inputs.
You can test the new logic there.

@quasilyte quasilyte merged commit fa0a170 into go-critic:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peakle @quasilyte