New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkers: add new checker stringsCompare #1195
Conversation
I would do this in 2 steps:
|
@cristaloleg, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, cover all cases with tests.
I don't see -1 value case.
Whether possible, all corner cases should be tested.
It's also a good practice to have "fixed" code examples in the negative tests suite.
For example, if linter suggests >
operator, negative tests suite should contain the suggested code snippet, to be sure that this replacements does not trigger any other warning.
LGTM. |
pr for: #1167