optimize deprecatedComment_checker: delete regexp usage

[peakle]

pr for: #1183
benchmarks in progress

[quasilyte]

We may need more tests to make sure that nothing is broken after this optimization. Could you add some, just to be sure?

[peakle]

We may need more tests to make sure that nothing is broken after this optimization. Could you add some, just to be sure?

added test cases

[quasilyte]

Benchmarks are not necessary if you can measure that gocritic becomes faster after these changes.
The code looks good so far.

Maybe https://github.com/sharkdp/hyperfine can help here.

[peakle]

Benchmarks are not necessary if you can measure that gocritic becomes faster after these changes. The code looks good so far.

Maybe https://github.com/sharkdp/hyperfine can help here.

i executed old and new version on https://github.com/kubernetes/kubernetes and as i see call graph looks better

but also i found that now it impossible to parse multiline comments like this one:

// ComponentStatusList represents the list of component statuses
// Deprecated: This API is deprecated in v1.19+
type ComponentStatusList struct {}

will fix it in new pr :)