Move out embedded rules from checkers/checkers.go #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
approved these changes
Jan 2, 2022
|
Nice. I was always struggling to remember where do we keep the code related to the embedded rules. |
quasilyte
approved these changes
Jan 2, 2022
tony2001
added a commit
to tony2001/go-critic
that referenced
this pull request
Jan 4, 2022
…01/go-critic into ignore_labeled_continue_in_select * 'ignore_labeled_continue_in_select' of github.com:tony2001/go-critic: checkers: move out embedded rules from checkers.go (go-critic#1186) cmd/gocritic: add -cpuprofile and -memprofile flags (go-critic#1185) checker/whyNoLint: compile regex when it is needed (go-critic#1182) checkers: add enable/disable flags to ruleguard checker (go-critic#1181) checkers: add io.WriteString patterns to preferFprint (go-critic#1180) checkers: fix equalFold rules autofix templates (go-critic#1178) checkers: rename undefinedFormatting to dynamicFmtString (go-critic#1174) checkers: add dynamicFmtString checker (go-critic#1156) update ruleguard (go-critic#1173) checkers: add tests for go-critic#1166 (go-critic#1172) checkers): treat //noinspection as pragma in commentFormatting (go-critic#1166) checkers: add At() for httpNoBody checker (go-critic#1164) tools: move tools into own module (go-critic#1162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move out embedded rules from checkers/checkers.go to checkers/embedded_rules.go
Issue: #1177