Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tools into own module. #1162

Merged
merged 1 commit into from Dec 7, 2021
Merged

Move tools into own module. #1162

merged 1 commit into from Dec 7, 2021

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Dec 7, 2021

Closes #34.

@cristaloleg
Copy link
Member

Is it exactly #34 ?

@AlekSi
Copy link
Contributor Author

AlekSi commented Dec 7, 2021

Doh! It is for quasilyte/go-consistent#34

@quasilyte
Copy link
Member

The failure looks unrelated.
It looks like one of the rules gives a different warning location now.
I'll investigate it later.

@quasilyte quasilyte merged commit e394bba into go-critic:master Dec 7, 2021
This was referenced Dec 7, 2021
Open
Closed
@quasilyte
Copy link
Member

Thank you! 🎉

@AlekSi AlekSi deleted the tools-modules branch December 7, 2021 17:35
tony2001 added a commit to tony2001/go-critic that referenced this pull request Jan 4, 2022
@tony2001
Merge branch 'ignore_labeled_continue_in_select' of github.com:tony20…
8dbc237 
…01/go-critic into ignore_labeled_continue_in_select

* 'ignore_labeled_continue_in_select' of github.com:tony2001/go-critic:
  checkers: move out embedded rules from checkers.go (go-critic#1186)
  cmd/gocritic: add -cpuprofile and -memprofile flags (go-critic#1185)
  checker/whyNoLint: compile regex when it is needed (go-critic#1182)
  checkers: add enable/disable flags to ruleguard checker (go-critic#1181)
  checkers: add io.WriteString patterns to preferFprint (go-critic#1180)
  checkers: fix equalFold rules autofix templates (go-critic#1178)
  checkers: rename undefinedFormatting to dynamicFmtString (go-critic#1174)
  checkers: add dynamicFmtString checker (go-critic#1156)
  update ruleguard (go-critic#1173)
  checkers: add tests for go-critic#1166 (go-critic#1172)
  checkers): treat //noinspection as pragma in commentFormatting (go-critic#1166)
  checkers: add At() for httpNoBody checker (go-critic#1164)
  tools: move tools into own module (go-critic#1162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlekSi @cristaloleg @quasilyte