ignore labeled continue in select statement #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Sorry for the late review. I would like to merge it, but could you fix the lining errors first? If you don't have gocritic sources locally anymore, I can figure something out and fix that for you. |
|
Oh, I didn't know about |
.. in nested for loops this fixes issue go-critic#1130 and adds a test for it
tony2001
force-pushed
the
ignore_labeled_continue_in_select
branch
from
8dbc237
to
f65d762
Compare
quasilyte
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. in nested for loops
this fixes issue #1130 and adds a test for it