Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defer in loop checker #1145

Merged
merged 3 commits into from Oct 26, 2021
Merged

Add defer in loop checker #1145

merged 3 commits into from Oct 26, 2021

Conversation

peakle
Copy link
Contributor

@peakle peakle commented Oct 24, 2021

No description provided.

@peakle peakle changed the title Add defer in cycle checker Add defer in loop checker Oct 24, 2021
@peakle
Copy link
Contributor Author

peakle commented Oct 24, 2021

PR for extern-testdata: go-critic/extern-testdata#1

cristaloleg
cristaloleg reviewed Oct 25, 2021
View reviewed changes
checkers/checkers_test.go Outdated Show resolved Hide resolved
checkers/deferInLoop_checker.go Outdated Show resolved Hide resolved
@quasilyte
Copy link
Member

LGTM.
@cristaloleg, what do you think?
If we're merging this, go-critic/extern-testdata#1 should be merged prior to this PR, so the pipeline passes.

@quasilyte quasilyte mentioned this pull request Oct 26, 2021
Merged
@quasilyte quasilyte merged commit c217bcd into go-critic:master Oct 26, 2021
@peakle peakle deleted the deferInCycle branch October 27, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

@quasilyte quasilyte quasilyte approved these changes

Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peakle @quasilyte @cristaloleg