From 8df9d7e15948e10a42b77b80ec1afd880b40d45f Mon Sep 17 00:00:00 2001 From: "Iskander (Alex) Sharipov" Date: Wed, 10 Aug 2022 00:21:33 +0300 Subject: [PATCH] checkers: turn `init()` for embedded rules into exported func (#1246) The `checkers` package user should use `checkers.InitEmbeddedRules()` if ruleguard-based rules should be enabled. Fixes #1218 --- checkers/embedded_rules.go | 2 +- cmd/gocritic/main.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/checkers/embedded_rules.go b/checkers/embedded_rules.go index d9ede0bcc..8a53ee5e5 100644 --- a/checkers/embedded_rules.go +++ b/checkers/embedded_rules.go @@ -15,7 +15,7 @@ import ( //go:generate go run ./rules/precompile.go -rules ./rules/rules.go -o ./rulesdata/rulesdata.go -func init() { +func InitEmbeddedRules() { filename := "rules/rules.go" fset := token.NewFileSet() diff --git a/cmd/gocritic/main.go b/cmd/gocritic/main.go index b469c89c2..8eb38f439 100644 --- a/cmd/gocritic/main.go +++ b/cmd/gocritic/main.go @@ -1,13 +1,14 @@ package main import ( - _ "github.com/go-critic/go-critic/checkers" // Register go-critic checkers + "github.com/go-critic/go-critic/checkers" // Register go-critic checkers "github.com/go-critic/go-critic/framework/lintmain" ) var Version = "v0.0.0-SNAPSHOT" func main() { + checkers.InitEmbeddedRules() lintmain.Run(lintmain.Config{ Name: "gocritic", Version: Version,