Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Route Matching Comment in chi.go #879

Open
knbr13 opened this issue Dec 3, 2023 · 0 comments · May be fixed by #887
Open

Incorrect Route Matching Comment in chi.go #879

knbr13 opened this issue Dec 3, 2023 · 0 comments · May be fixed by #887

Comments

@knbr13
Copy link

knbr13 commented Dec 3, 2023

The comment on line 54 of the chi.go file contains inaccurate information regarding route matching. It states:

// "/page/{other}/index" also matches "/page/intro/latest"

However, this is not accurate. The route /page/{other}/index expects a path component after /page/ followed by /index. It does not match paths like /page/intro/latest.

Proposed Correction:

Update the comment on line 54 to accurately reflect the behavior of the /page/{other}/index route. For example:

// "/page/{other}/index" matches "/page/some_value/index" but not "/page/intro/latest"

This correction will provide users with accurate information about the route's matching behavior.

@jtams jtams linked a pull request Dec 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant