Support matching parameters that containing the delimiter #811
Conversation
|
@pkieltyka @VojtechVitek please have a look! PS: this might require a major version bump but I think it's worth it |
There was a problem hiding this comment.
Thanks @6543. I think this looks great!
It'd be nice to provide a high-level description of the changes. Something like:
Given this route
r.Get("/files/{file}.{ext}", handleFileExt)and a request to /files/photos.tar.gz path
chi will match the longest leftmost parameter first (same as Regex or filepath.Ext()):
fmt.Println(chi.URLParam(req, "file"))
fmt.Println(chi.URLParam(req, "ext"))
- photos
- tar.gz
+ photos.tar
+ gzYes, this can be considered a breaking change. But I'm not sure if it's worth the major version bump.
Anyway, let's see what @pkieltyka has to say
| if segmentlen == -1 { | ||
| segmentlen = len(xsearch) | ||
| } else { | ||
| segmentlen += 1 // just keep the old code working |
There was a problem hiding this comment.
I'm not sure how the "old code" was exactly :) Can you explain what this does (and why) in the comment?
|
These failed cases do look bad imho. I think a option per-parameter option to catch a dot is needed. Maybe expose a constraints regex to the user. like rails does: https://prathamesh.tech/2020/06/15/allowing-dots-in-rails-routes/ If that is not possible, maybe some special syntax like |
close #781