New deployment of audited contracts #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
approved these changes
Jan 23, 2020
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@gnosis.pm/dex-contracts", | |||
| "version": "0.1.4", | |||
| "version": "0.2.0", | |||
| @@ -66,7 +66,7 @@ | |||
| "devDependencies": { | |||
| "@gnosis.pm/mock-contract": "^3.0.8", | |||
| "@gnosis.pm/owl-token": "^3.1.0", | |||
| "@gnosis.pm/solidity-data-structures": "^1.2.2", | |||
| "@gnosis.pm/solidity-data-structures": "^1.2.4", | |||
There was a problem hiding this comment.
Just curious what this version bump is for?
Missed it in the PR description.
|
We'll adapt the UI, dex-js, telegram and subgraph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the long-awaited deployment of the audited contracts.
It bumps the version of the "@gnosis.pm/solidity-data-structures", as I used the new library for the deployments.
Note: Actually, I was running the deployment with the old migration scripts, as the current migration scripts still need to be fixed
I also decided for version 0.2.0, as we have the new contracts, but I did not want to go for 1.0.0, as the migration scripts are still to be fixed.
I was also listing the stablecoins and placed some basic orders on the exchange.
testplan:
Check that MAX_TOUCHED_ORDERS ==30 in etherscan
https://etherscan.io/address/0x6F400810b62df8E13fded51bE75fF5393eaa841F#code
Check that new library was used:
https://etherscan.io/address/0xED4d05496C71e71cC2A8726af1242C22108d1761#code
and address(0x) can not be added.
PS:
This PR replaces #498