Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown table support in markdown #267

Closed
z-george-ma opened this issue Jun 20, 2018 · 5 comments
Closed

Markdown table support in markdown #267

z-george-ma opened this issue Jun 20, 2018 · 5 comments
Labels

Comments

@z-george-ma
Copy link

Just wondering, is it possible to have markdown tables supported in FsNotes? Something like -

id type price
1 apple $2
@davistech
Copy link

Agree. Table support is important.

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jul 4, 2018

Agreed table support is important.

The issue here is that tables are an extension to the original Markdown spec, or the current CommonMark spec. MultiMarkdown introduced a table syntax extension to Markdown and GitHub Flavored Markdown continues uses that syntax through an extension to CommonMark.

Thus, it is not possible to find a Markdown syntax highlighter that supports tables. So this would need changes to the syntax highlighter used by FSNotes: highlight.js development of which has pretty much stalled. A good alternative to highlight.js is proving to be elusive. See #130 for that.

Maybe we can do without table syntax highlighting…

But tables would also need changes to the Markdown renderer used by FSNotes, Down, which follows the CommonMark spec (therefore: no tables) and their response on this issue is a polite “it’s possible, because GitHub have done it, but we won’t be doing it ourselves”: johnxnguyen/Down#36

@gingerbeardman
Copy link
Collaborator

Just to keep relevant information together:

Table extension code to cmark, by GitHub
commonmark/cmark@master...github:master

@glushchenko
Copy link
Owner

Added in 2.5.6 for macOS and 2.5.0 for iOS

@gingerbeardman
Copy link
Collaborator

Works for me.

2.5.6 macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants