Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook document features #269

Open
nayeemrmn opened this issue Oct 16, 2023 · 1 comment
Open

Notebook document features #269

nayeemrmn opened this issue Oct 16, 2023 · 1 comment

Comments

@nayeemrmn
Copy link

3.17 feature: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notebookDocument_synchronization

The Deno LSP would use this for jupyter notebook intellisense. Specifically having continuity for variables between TypeScript cells.

cc @ebkalderon You excluded this from #255 because it was handled by #229, but that PR was closed without merge.

P.S. It would be nice to have a #[serde(flatten)] custom: Option<Map<String, Value>> field in ServerCapabilities. With tower-lsp we could get ahead of not-yet-supported request methods using LspServiceBuilder::custom_method(). But there's no way of doing that with capabilities.

@nayeemrmn
Copy link
Author

Ah there's a PR: #268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant