Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues bundling main branch #5

Closed
drnic opened this issue Aug 16, 2022 · 10 comments
Closed

Issues bundling main branch #5

drnic opened this issue Aug 16, 2022 · 10 comments

Comments

@drnic
Copy link

drnic commented Aug 16, 2022

I cannot bundle from main branch. I think the issue is with sha 7b086ba

gem "flow_client", github: "glucode/flow_client"

When I bundle this I get an error:

$ bundle
Fetching https://github.com/glucode/flow_client.git
Fetching gem metadata from https://rubygems.org/......
Could not find gem 'flow_client' with platform 'arm64-darwin-20' in https://github.com/glucode/flow_client.git (at main@8ec7b4e).

The source contains the following gems matching 'flow_client':
  * flow_client-0.2.2-arm64-darwin-21

The same occurs if I run this inside a docker container on my M2 macbook laptop. I haven't found another laptop arch to test.

But gem "flow_client" works as expected; but its missing some fixes we would like.

I worked backwards, and when I removed sha 7b086ba then I could bundle.

@drnic drnic changed the title Cut new release? Issues bundling branch Issues bundling main branch Aug 16, 2022
@drnic
Copy link
Author

drnic commented Aug 16, 2022

I have a working branch (minus the last two commits) for anyone else:

gem "flow_client", github: "drnic/flow_client", branch: "finding-working-sha"

@nduplessis
Copy link
Collaborator

Thanks for reporting this @drnic. I have pushed a fix for this to main and released 0.2.3

@drnic
Copy link
Author

drnic commented Aug 21, 2022

0.2.3 didn't work. So... I don't know. Damnit. Sorry. Anyone have an idea?

$ bundle
Fetching gem metadata from https://enterprise.contribsys.com/..
Fetching gem metadata from https://rubygems.org/......
Could not find gem 'flow_client (= 0.2.3)' with platform 'arm64-darwin-20' in rubygems repository https://rubygems.org/ or installed locally.

The source contains the following gems matching 'flow_client (= 0.2.3)':
  * flow_client-0.2.3-arm64-darwin-21

@drnic
Copy link
Author

drnic commented Aug 21, 2022

Ooh, it worked eventually.

  1. Remove gem "flow_client" from Gemfile and bundle
  2. Add gem "flow_client" back and bundle`

@drnic
Copy link
Author

drnic commented Aug 21, 2022

Actually, no, that means 0.2.2 was installed; not 0.2.3. Something about 0.2.3 isn't available to my M2 mac :/

@drnic
Copy link
Author

drnic commented Aug 21, 2022

Confirm that HEAD also won't build:

gem "flow_client", github: "glucode/flow_client"

But my branch does:

gem "flow_client", github: "drnic/flow_client", branch: "finding-working-sha"

🤷‍♂️

@nduplessis
Copy link
Collaborator

@drnic it seems like this is a related to rubygems/rubygems#5807

What version of rubygems and bundler are you running?

@nduplessis
Copy link
Collaborator

@drnic I've reverted the platform changes referenced in your earlier comment on main, do you mind trying installing from head and letting me know if that works for you please?

@drnic
Copy link
Author

drnic commented Aug 21, 2022

Thanks. I've upgraded to latest rubygems 3.3.20, and bundler 2.3.14 (also 2.3.19), and gem "flow_client", github: "glucode/flow_client" now installs.

@nduplessis
Copy link
Collaborator

Thanks for confirming @drnic, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants