Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shortname to utf8 emoji support is incomplete/broken #1268

Open
etamme opened this issue Aug 25, 2023 · 2 comments · May be fixed by #1278
Open

shortname to utf8 emoji support is incomplete/broken #1268

etamme opened this issue Aug 25, 2023 · 2 comments · May be fixed by #1278

Comments

@etamme
Copy link

etamme commented Aug 25, 2023

I am using the glowing-bear.org website, Glowing Bear version 0.9.0

I noticed that some shortname -> utf8 emoji conversion is not happening, despite the shortname being supported by emojione.

I started doing a test by selecting 10 random shortnames from https://raw.githubusercontent.com/joypixels/emojione/master/emoji.json and feeding them to glowingbear's input bar. below is an example.

👋 😃 🚇 🍢 ☁️ 🧑 🥪 😳 🦹 🥢 🎿

I can not figure out why this is happening, but some simple ones like ❤️ which used to work no longer work. I dont know if there has been some further checks added around the emoji support.
@etamme
Copy link
Author

etamme commented Aug 25, 2023

edit: github converted ALL the shortnames so I will re-post the plaintext words below are the shortnames that glowing bear failed to convert, i removed the :: so github would not convert them

👋 😃 🚇 🍢 cloud adult sandwich 😳 supervillain chopsticks 🎿

@lorenzhs
Copy link
Member

lorenzhs commented Sep 9, 2023 •
edited

Does it work for you on https://latest.glowing-bear.org/? Because I just tried with :chopsticks: and it worked. Maybe some of the newer ones are indeed missing (emojione isn't exactly up to date) but the basics should work

@txdv txdv linked a pull request Apr 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use emoji-regex package to check for emojis txdv/glowing-bear
2 participants
@etamme @lorenzhs